Skip to content

Sync PR for 1.9.0#1852

Merged
subodhr258 merged 11 commits intomainfrom
develop
May 7, 2026
Merged

Sync PR for 1.9.0#1852
subodhr258 merged 11 commits intomainfrom
develop

Conversation

@subodhr258
Copy link
Copy Markdown
Collaborator

This pull request updates the plugin to version 1.9.0 and introduces several important improvements focused on user experience, accessibility, and reliability, especially around video autoplay and hover interactions. It also includes messaging and branding refinements for a more consistent, less branded UI, and addresses a WooCommerce integration notice. Below are the most significant changes:

Autoplay and Hover Behavior Improvements

  • Autoplay and hover-select are now mutually exclusive: when autoplay is enabled, hover-select is automatically reset to 'none' in both the editor and frontend rendering, preventing conflicting behaviors. This is enforced in both the block editor (VideoEdit in edit.js) and the PHP template (godam-player.php). The UI disables the hover option when autoplay is active and updates the help text accordingly. [1] [2] [3] [4]
  • The hover manager in the JS player now skips initialization if autoplay is enabled, preventing legacy or cached content from triggering hover actions on autoplay videos.

User Interface and Branding Updates

  • Block titles, labels, and placeholders have been updated to use more generic terms (e.g., "Video", "Audio", "Document") instead of "GoDAM", for a less branded and more user-friendly experience across all blocks and UI elements. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

WooCommerce Integration Notice Messaging

  • The WooCommerce integration promo notice has been rewritten for clarity and a more action-oriented tone, with messaging tailored to the user's context (e.g., activation, installation, or upgrade prompts).

Reliability and Error Handling

  • The admin expired API key notice now checks the runtime status from the correct option, preventing false "expired" banners when the server is temporarily unreachable.
  • The JS player now more robustly detects the instance ID by checking both the video element and its descendants.

Styling and Accessibility

  • Improved modal visibility handling in the video gallery block for better accessibility and interaction, using visibility in addition to opacity. [1] [2]

Version updates:

  • Bumped plugin and package versions to 1.9.0 in all relevant files. [1] [2] [3] [4]

These changes collectively enhance the user experience, prevent conflicting behaviors, and modernize the plugin’s interface and messaging.

subodhr258 and others added 10 commits May 4, 2026 13:49
Sync main with develop after 1.8.0 release
Update: Admin notices as per Marketing
* chore: Rename GoDAM blocks

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…nent (#1846)

* fix: Disable hover option when autoplay is enabled in VideoEdit component

* fix: Ensure hover behavior is disabled when autoplay is enabled across components

Address the frontend rendering hoverSelect gating

---------

Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues ❌ Errors ⚠️ Warnings
14 0 14

⚠️ Warnings (14)

📁 composer.json (1 warning)
📍 Line 🔖 Check 💬 Message
0 missing_composer_json_file The "/vendor" directory using composer exists, but "composer.json" file is missing.
📁 readme.txt (2 warnings)
📍 Line 🔖 Check 💬 Message
0 mismatched_plugin_name Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM".
0 trademarked_term The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name.
📁 assets/build/css/main.css (1 warning)
📍 Line 🔖 Check 💬 Message
0 EnqueuedStylesScope This style is being loaded in all contexts.
📁 assets/src/libs/analytics.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/05/07/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
📁 assets/build/js/main.min.js (5 warnings)
📍 Line 🔖 Check 💬 Message
0 EnqueuedScriptsScope This script is being loaded in all frontend contexts.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/2026/05/07/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0 NonBlockingScripts.NoStrategy This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the plugin release to 1.9.0 and refines frontend/editor behavior and UI copy, with emphasis on preventing conflicting video interactions (autoplay vs hover), improving reliability of admin notices, and reducing “GoDAM”-heavy labeling in block/editor surfaces.

Changes:

  • Bumps plugin/package stable tags and versions to 1.9.0.
  • Enforces autoplay vs hover-select mutual exclusivity across editor, PHP render, and frontend JS hover manager.
  • Updates integration messaging/UI labels (including WooCommerce notice/button copy) and improves a few reliability/accessibility behaviors (instanceId lookup; modal visibility toggling).

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
readme.txt Updates Stable tag to 1.9.0.
README.md Updates Stable tag to 1.9.0.
package.json Bumps package version to 1.9.0.
package-lock.json Bumps lockfile package version metadata to 1.9.0.
godam.php Bumps plugin header + RTGODAM_VERSION to 1.9.0.
inc/templates/godam-player.php Forces hoverSelect to none when autoplay is enabled; minor PHPCS ignore formatting.
assets/src/js/godam-player/managers/hoverManager.js Skips hover manager initialization when autoplay is enabled.
assets/src/js/godam-player/api/player.js Makes instanceId detection more robust by checking descendants.
assets/src/blocks/godam-player/edit.js Resets hoverSelect to none when autoplay is toggled on; disables hover UI when autoplay is enabled; updates labels.
assets/src/blocks/godam-player/block.json Renames block title to “Video”; fixes textdomain; adds keyword.
assets/src/blocks/godam-player/index.js Updates block icon alt text to be less branded.
assets/src/blocks/godam-player/style.scss Updates comment branding in wrapper styles.
assets/src/blocks/godam-player/editor.scss Updates comment branding in editor styles.
assets/src/blocks/godam-pdf/edit.js Updates placeholder label to “Document”.
assets/src/blocks/godam-pdf/block.json Renames block title to “Document”; adds keyword.
assets/src/blocks/godam-audio/edit.js Updates placeholder label to “Audio”.
assets/src/blocks/godam-audio/block.json Renames block title to “Audio”; adds keyword.
assets/src/blocks/godam-gallery-v2/block.json Renames block title to “Video Gallery”.
assets/src/blocks/godam-gallery-v2/edit.js Updates placeholder label to “Video”.
assets/src/blocks/godam-gallery-v2/render.php Updates frontend placeholder copy to “Video”.
assets/src/blocks/godam-gallery-v2/style.scss Adds visibility toggling for modal/overlay state.
pages/video-editor/VideoJSPlayer.js Allows add-on layer types from localized config; renders add-on icons as <img>.
pages/video-editor/style.scss Adds styling for add-on layer indicator icons rendered as <img>.
pages/video-editor/components/SidebarLayers.js Disables layer selection button when required integration/plugin is inactive.
pages/godam/components/tabs/IntegrationsSettings/IntegrationsSettings.jsx Updates an inline comment.
pages/godam/components/tabs/IntegrationsSettings/IntegrationActionButton.jsx Changes CTA text from “Purchase Now” to “Upgrade Plan”.
pages/godam/components/tabs/IntegrationsSettings/integration-tabs.js Changes WooCommerce badge label from “Pro” to “Beta”.
admin/class-rtgodam-transcoder-admin.php Prevents false “expired key” notices on verification failures; rewrites WooCommerce promo notice messaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pages/video-editor/VideoJSPlayer.js
Comment thread assets/src/blocks/godam-gallery-v2/style.scss
Comment thread assets/src/blocks/godam-gallery-v2/style.scss
@subodhr258 subodhr258 merged commit d637d4b into main May 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants